Skip to content

Python points-to. Improve handling of socket module.#1407

Merged
taus-semmle merged 1 commit into
github:masterfrom
markshannon:python-fix-odasa-7104
Jun 11, 2019
Merged

Python points-to. Improve handling of socket module.#1407
taus-semmle merged 1 commit into
github:masterfrom
markshannon:python-fix-odasa-7104

Conversation

@markshannon

@markshannon markshannon commented Jun 5, 2019

Copy link
Copy Markdown
Contributor

... or any module that dynamically generates "__all__".
If __all__ is created dynamically, assume that all 'public' symbols as exported.
This means that we now recognise that socket and other symbols imported from _socket are included in from socket import *.

@markshannon markshannon added this to the 1.21.0 milestone Jun 6, 2019

@taus-semmle taus-semmle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@taus-semmle taus-semmle merged commit 1ff67f7 into github:master Jun 11, 2019
taus-semmle added a commit that referenced this pull request Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants